Skip to content

update segwit derivation paths#851

Closed
smk762 wants to merge 2 commits intomasterfrom
segwit-dv
Closed

update segwit derivation paths#851
smk762 wants to merge 2 commits intomasterfrom
segwit-dv

Conversation

@smk762
Copy link
Copy Markdown
Collaborator

@smk762 smk762 commented Oct 30, 2023

@smk762 smk762 requested review from cipig and dimxy October 30, 2023 06:22
@dimxy
Copy link
Copy Markdown

dimxy commented Oct 30, 2023

I can see several segwit coins with no derivation path set at all.
We did not assign it because there is no standard value for those coins?

@smk762
Copy link
Copy Markdown
Collaborator Author

smk762 commented Nov 3, 2023

I can see several segwit coins with no derivation path set at all. We did not assign it because there is no standard value for those coins?

Info was sourced from https://github.com/satoshilabs/slips/blob/master/slip-0044.md a while ago.
trezor_coin value comes from https://trezor.io/coins where available.

I've added a check to the config gen script to highlight the coins with missing / incorrect derivation path, results are:

Segwit coins with no derivation path: ['BSTY-segwit', 'tQTUM-segwit', 'tBTC-segwit', 'WHIVE-segwit']
Segwit coins with bad derivation path: []
Segwit coins with no trezor coin: [
    'BSTY-segwit',
    'CDN-segwit',
    'CY-segwit',
    'LBC-segwit',
    'LCC-segwit',
    'WCN-segwit',
    'tQTUM-segwit',
    'tBTC-segwit',
    'XEP-segwit',
    'XMY-segwit',
    'WHIVE-segwit'
]

I rechecked the sources and found no new data to update the coins file at this time.

@dimxy
Copy link
Copy Markdown

dimxy commented Nov 4, 2023

Info was sourced from https://github.com/satoshilabs/slips/blob/master/slip-0044.md a while ago.

I see, I'll discuss with @shamardy what we should do with coins for which there is no assigned coin type

@smk762 smk762 added the on hold label Dec 18, 2023
Copy link
Copy Markdown

@dimxy dimxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

segwit coin config ("format": "segwit") must have derivation path starting with m/84'

@smk762
Copy link
Copy Markdown
Collaborator Author

smk762 commented May 30, 2025

closing as stale, issue solved by https://github.com/KomodoPlatform/coins/pull/1355

@smk762 smk762 closed this May 30, 2025
@smk762 smk762 deleted the segwit-dv branch May 30, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

segwit derivation paths

3 participants